Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          39     39           
  Branches        3      3           
=====================================
  Hits           39     39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396049b...26b7c55. Read the comment docs.

This has been discussed a bit in #110 already, but I'm not convinced the type dependencies are actually wrong here. Because of semver versioning, the types should resolve to a single version, so long as they are compatible semver ranges.

In the case of lerna, npm link (which lerna uses under the hood) is well documented as causing issues when resolving type definitions.

It's an annoying situation for me because either I make the type definitions a dependency and have it install the right one for all the cases when someone doesn't care about they type definition (i.e. non-typescript user or typescript user without that dependency themselves), or I have them as peerDependencies and make everyone who doesn't care about them get a peerDependency warning on installation (less important for a typescript user without that dependency, as they should be installing it anyone, but a pain for a non-typescript user).

Closing this. See #110 for details.